Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 lock erroneously passed by value (internal/net/test) #1874

Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Nov 25, 2022

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

…l/net test

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 30.56% // Head: 30.55% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c292a3d) compared to base (1fbd3bb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
- Coverage   30.56%   30.55%   -0.02%     
==========================================
  Files         367      367              
  Lines       33821    33821              
==========================================
- Hits        10338    10333       -5     
- Misses      23074    23076       +2     
- Partials      409      412       +3     
Impacted Files Coverage Δ
...nt/core/ngt/service/vqueue/uninserted_index_map.go 75.80% <0.00%> (-3.23%) ⬇️
pkg/agent/core/ngt/service/option.go 89.57% <0.00%> (-1.85%) ⬇️
internal/worker/worker.go 82.30% <0.00%> (-0.77%) ⬇️
internal/core/algorithm/ngt/ngt.go 63.93% <0.00%> (+0.64%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi merged commit 8a157f9 into main Nov 25, 2022
@vankichi vankichi deleted the refactor/VET-V0008/lock-erroneously-passed-by-value/net-test branch November 25, 2022 04:07
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants