Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deepsoure configuration #1881

Merged
merged 16 commits into from
Dec 7, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 3, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

In this PR updates deepsource configuration and update README.md and fixed deepsource warning
Deepsource configuration changes are below.

  1. add gofumpt as a Go code transformer
  2. add prettier as Yaml, Markdown, html, json code transfomer
  3. add shell & secret analyzer

and updated dependencies also.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 3, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 3, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af237cf
Status: ✅  Deploy successful!
Preview URL: https://43c29db4.vald.pages.dev
Branch Preview URL: https://refactor-deepsource-update-d.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/deepsource/update-deepsource-configuration branch 2 times, most recently from d15cad7 to ec455bf Compare December 3, 2022 05:05
@kpango kpango requested review from vankichi and hlts2 December 3, 2022 05:18
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 30.35% // Head: 30.41% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (af237cf) compared to base (92682d6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   30.35%   30.41%   +0.05%     
==========================================
  Files         365      365              
  Lines       33761    33761              
==========================================
+ Hits        10248    10268      +20     
+ Misses      23098    23081      -17     
+ Partials      415      412       -3     
Impacted Files Coverage Δ
internal/worker/worker.go 82.30% <0.00%> (ø)
internal/errgroup/group.go 95.00% <0.00%> (+2.00%) ⬆️
internal/net/http/middleware/timeout.go 93.33% <0.00%> (+2.22%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.65% <0.00%> (+9.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 3, 2022

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

hlts2
hlts2 previously approved these changes Dec 6, 2022
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango force-pushed the refactor/deepsource/update-deepsource-configuration branch 3 times, most recently from 1cf8201 to 78b1d7e Compare December 6, 2022 02:55
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the refactor/deepsource/update-deepsource-configuration branch from 78b1d7e to 1a500e8 Compare December 6, 2022 03:06
deepsource-autofix bot and others added 3 commits December 6, 2022 03:06
This reverts commit 1a500e8.

Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
versions/GO_VERSION Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2022

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango requested a review from hlts2 December 7, 2022 01:33
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Show resolved Hide resolved
@hlts2 hlts2 requested a review from vankichi December 7, 2022 02:32
@hlts2 hlts2 merged commit 4e10e17 into main Dec 7, 2022
@hlts2 hlts2 deleted the refactor/deepsource/update-deepsource-configuration branch December 7, 2022 02:37
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants