-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
divide agent errors for QBG and Faiss implementation #1924
divide agent errors for QBG and Faiss implementation #1924
Conversation
Signed-off-by: kpango <kpango@vdaas.org>
[CHATOPS:HELP] ChatOps commands.
|
package errors | ||
|
||
var ( | ||
// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godot: Comment should end in a period
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
Command | Usage |
---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Codecov ReportBase: 50.23% // Head: 29.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
===========================================
- Coverage 50.23% 29.99% -20.25%
===========================================
Files 231 366 +135
Lines 13464 33704 +20240
===========================================
+ Hits 6764 10109 +3345
- Misses 6499 23188 +16689
- Partials 201 407 +206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
package errors | ||
|
||
var ( | ||
// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Comment should end in a period (godot)
…rors-for-qbg-and-faiss
Deploying with
|
Latest commit: |
4d524a7
|
Status: | ✅ Deploy successful! |
Preview URL: | https://66606658.vald.pages.dev |
Branch Preview URL: | https://refactor-internal-errors-div.vald.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kpango kpango@vdaas.org
Description:
SSIA
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: