Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divide agent errors for QBG and Faiss implementation #1924

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 19, 2023

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.4
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

package errors

var (
// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godot: Comment should end in a period


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 50.23% // Head: 29.99% // Decreases project coverage by -20.25% ⚠️

Coverage data is based on head (4d524a7) compared to base (97eed29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1924       +/-   ##
===========================================
- Coverage   50.23%   29.99%   -20.25%     
===========================================
  Files         231      366      +135     
  Lines       13464    33704    +20240     
===========================================
+ Hits         6764    10109     +3345     
- Misses       6499    23188    +16689     
- Partials      201      407      +206     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/gateway/filter/main.go 0.00% <ø> (ø)
cmd/gateway/lb/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
cmd/tools/cli/vdctl/main.go 0.00% <ø> (ø)
internal/observability/metrics/info/info.go 0.00% <0.00%> (-100.00%) ⬇️
internal/errors/vald.go 50.00% <0.00%> (-16.67%) ⬇️
... and 260 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

package errors

var (
// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Comment should end in a period (godot)

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jan 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d524a7
Status: ✅  Deploy successful!
Preview URL: https://66606658.vald.pages.dev
Branch Preview URL: https://refactor-internal-errors-div.vald.pages.dev

View logs

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 4da13b0 into main Jan 19, 2023
@kpango kpango deleted the refactor/internal-errors/divide-agent-ngt-errors-for-qbg-and-faiss branch January 19, 2023 07:35
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants