Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatops command /format output message if nothing updated #2021

Merged
merged 1 commit into from
May 2, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Apr 27, 2023

Description:

This PR update the ChatOps /format command to output **[FORMAT]** Nothing to format. message if nothing is updated, to let user know the command is finished with success.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

We cannot test this changes on PR unless we merged this PR. (Github action always use main branch to trigger CI)

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kevindiu kevindiu changed the title Format chatops output message if nothing updated Chatops command /format output message if nothing updated Apr 27, 2023
@kevindiu kevindiu marked this pull request as ready for review April 27, 2023 07:22
@kevindiu kevindiu requested review from vankichi, hlts2 and a team and removed request for vankichi May 1, 2023 04:45
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevindiu kevindiu requested review from a team and removed request for a team May 1, 2023 05:24
@vankichi vankichi requested review from a team and removed request for a team May 1, 2023 05:55
@kpango kpango requested review from a team and removed request for a team May 1, 2023 05:56
@kevindiu kevindiu requested review from vankichi, kpango and a team and removed request for a team May 1, 2023 06:45
@kevindiu kevindiu merged commit 9b2f756 into main May 2, 2023
@kevindiu kevindiu deleted the ci/chatops/format-cmd-output-finished branch May 2, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants