Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "make gotests/gen" command #2085

Merged
merged 14 commits into from
Jun 28, 2023
Merged

Update "make gotests/gen" command #2085

merged 14 commits into from
Jun 28, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 21, 2023

Description:

This PR updates make gotests/gen command with the following update:

  • Generate only New() test case in pkg/*/usecase package
  • Do not generate test cases under pkg/*/router, pkg/*/handler/rest package
  • Generate only exported function tests under pkg package
  • Comment out all the unimplemented test under the NOT IMPLEMENTED BELOW placeholder
  • Fix /gen-test ChatOpts error

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

Since the changes of the ChatOpts does not have any affect before the PR is merged, we need to create another PR to test it later.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7b6cfd
Status: ✅  Deploy successful!
Preview URL: https://6fa805e8.vald.pages.dev
Branch Preview URL: https://ci-update-gen-test-command.vald.pages.dev

View logs

@github-actions github-actions bot added type/ci and removed type/ci labels Jun 21, 2023
@kevindiu kevindiu requested review from a team, kmrmt and datelier and removed request for a team June 21, 2023 09:49
@github-actions github-actions bot added size/M and removed size/M labels Jun 22, 2023
@kevindiu kevindiu changed the title [WIP] Update "make gotests/gen" command Update "make gotests/gen" command Jun 22, 2023
@kevindiu kevindiu marked this pull request as ready for review June 22, 2023 09:14
kmrmt
kmrmt previously approved these changes Jun 23, 2023
.github/workflows/chatops.yml Outdated Show resolved Hide resolved
kevindiu and others added 14 commits June 28, 2023 14:52
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@github-actions github-actions bot added size/M and removed size/M labels Jun 28, 2023
@vankichi vankichi merged commit b8a2e20 into main Jun 28, 2023
20 checks passed
@vankichi vankichi deleted the ci/update-gen-test-command branch June 28, 2023 06:51
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants