Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update observability document #2086

Merged
merged 3 commits into from Jun 26, 2023
Merged

Update observability document #2086

merged 3 commits into from Jun 26, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jun 22, 2023 •
edited

Description:

I have the following new section to the observability document

  • simple command deploy
  • cleanup

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@hlts2 hlts2 self-assigned this Jun 22, 2023
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 23, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7a6c83
Status: ✅  Deploy successful!
Preview URL: https://e0a4c778.vald.pages.dev
Branch Preview URL: https://documentation-docs-update-co-s3vr.vald.pages.dev

View logs

@hlts2 hlts2 requested a review from vankichi June 23, 2023 02:17
vankichi
vankichi previously approved these changes Jun 23, 2023
View reviewed changes
hlts2 and others added 2 commits June 23, 2023 17:13
@hlts2
add simple command deploy section and cleanup section to observabilit…
933e84f 
…y document

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @vankichi
Update docs/user-guides/observability-configuration.md
156bc04 
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@hlts2 hlts2 force-pushed the documentation/docs/update-configuration-docs branch from 56d0699 to 156bc04 Compare June 23, 2023 08:13
@hlts2 @ykadowak
Update docs/user-guides/observability-configuration.md
a7a6c83 
Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
@hlts2 hlts2 requested review from ykadowak and vankichi June 23, 2023 08:36
@vankichi vankichi merged commit 7e247f6 into main Jun 26, 2023
16 checks passed
@vankichi vankichi deleted the documentation/docs/update-configuration-docs branch June 26, 2023 02:50
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@ykadowak ykadowak ykadowak approved these changes

@datelier datelier Awaiting requested review from datelier

Assignees

@hlts2 hlts2

Labels
priority/low size/M type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlts2 @vdaas-ci @vankichi @ykadowak