Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of contribution guide #2087

Merged
merged 2 commits into from Jun 23, 2023
Merged

Fix typo of contribution guide #2087

merged 2 commits into from Jun 23, 2023

Conversation

vankichi
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vankichi vankichi requested review from ykadowak, a team and kmrmt and removed request for a team June 23, 2023 07:04
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kmrmt
kmrmt previously approved these changes Jun 23, 2023
ykadowak
ykadowak previously approved these changes Jun 23, 2023
@vankichi vankichi dismissed stale reviews from ykadowak and kmrmt via 17c927e June 23, 2023 07:32
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1fea4d
Status: ✅  Deploy successful!
Preview URL: https://75905323.vald.pages.dev
Branch Preview URL: https://documentation-docs-fix-typo.vald.pages.dev

View logs

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/fix-typo branch from 17c927e to b1fea4d Compare June 23, 2023 07:33
@vankichi vankichi merged commit 2a487d2 into main Jun 23, 2023
16 checks passed
@vankichi vankichi deleted the documentation/docs/fix-typo branch June 23, 2023 07:50
ykadowak pushed a commit that referenced this pull request Jun 26, 2023
* 📝 Fix typo of contribution guide

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ Update .prh.yaml

Signed-off-by: vankichi <kyukawa315@gmail.com>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants