Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jaeger operator wait logic #2114

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Fix jaeger operator wait logic #2114

merged 3 commits into from
Jul 10, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jul 7, 2023

Description:

WHY

when I deployed the Jaeger component using make k8s/external/cert-manager/deploy k8s/monitoring/deploy, the deploy error occurred.

until kubectl run busybox --restart=Never --image=busybox --rm -it -- wget -q -S --spider "https://jaeger-operator-webhook-service.default.svc:443/mutate-jaegertracing-io-v1-jaeger"; do sleep 1; done
If you don't see a command prompt, try pressing enter.
pod "busybox" deleted
pod default/busybox terminated (Error)
wget: note: TLS certificate validation not implemented
wget: TLS error from peer (alert code 40): handshake failure
wget: error getting response: Connection reset by peer
pod "busybox" deleted
pod default/busybox terminated (Error)
If you don't see a command prompt, try pressing enter.
warning: couldn't attach to pod/busybox, falling back to streaming logs: unable to upgrade connection: container busybox not found in pod busybox_default
wget: note: TLS certificate validation not implemented
wget: TLS error from peer (alert code 40): handshake failure
wget: error getting response: Connection reset by peer
pod "busybox" deleted
pod default/busybox terminated (Error)

WHAT

I tried to wait for operator deployment instead of accessing the endpoint.

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@hlts2 hlts2 self-assigned this Jul 7, 2023
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vankichi
vankichi previously approved these changes Jul 8, 2023
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a3630f0
Status: ✅  Deploy successful!
Preview URL: https://ef763234.vald.pages.dev
Branch Preview URL: https://bugfix-k8s-fix-wait-for-oper.vald.pages.dev

View logs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 force-pushed the bugfix/k8s/fix-wait-for-operator branch from f024d9e to a3630f0 Compare July 10, 2023 03:02
@hlts2 hlts2 requested a review from vankichi July 10, 2023 03:12
@hlts2 hlts2 requested a review from kpango July 10, 2023 04:15
@hlts2 hlts2 merged commit 1e7f94c into main Jul 10, 2023
20 checks passed
@hlts2 hlts2 deleted the bugfix/k8s/fix-wait-for-operator branch July 10, 2023 04:17
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants