Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some linters to make ci faster #2116

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jul 10, 2023

Description:

  • Removed gocritic from golangci-lint because it was taking more than 30mins. Now it's just a few mins.
  • Fix depgurd settings

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f87b6f
Status: ✅  Deploy successful!
Preview URL: https://12fc05fb.vald.pages.dev
Branch Preview URL: https://fix-ci-golangci-lint-too-slo.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (a6d8701) 30.65% compared to head (60b4c4b) 30.66%.

❗ Current head 60b4c4b differs from pull request most recent head 5f87b6f. Consider uploading reports for the commit 5f87b6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
+ Coverage   30.65%   30.66%   +0.01%     
==========================================
  Files         347      347              
  Lines       34255    34262       +7     
==========================================
+ Hits        10501    10508       +7     
  Misses      23276    23276              
  Partials      478      478              
Impacted Files Coverage Δ
internal/cache/cacher/cacher.go 100.00% <ø> (ø)
internal/cache/cache.go 100.00% <100.00%> (ø)
internal/cache/gache/gache.go 100.00% <100.00%> (ø)
internal/cache/gache/option.go 100.00% <100.00%> (ø)
internal/cache/option.go 100.00% <100.00%> (ø)
internal/net/dialer.go 77.25% <100.00%> (-1.15%) ⬇️
internal/net/option.go 88.50% <100.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 36.06% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ykadowak ykadowak force-pushed the fix/ci/golangci-lint-too-slow branch from 60b4c4b to e31c533 Compare July 10, 2023 08:36
@ykadowak ykadowak changed the title [WIP] Fix/ci/golangci lint too slow remove some linters to make ci faster Jul 10, 2023
@ykadowak ykadowak requested review from a team, kpango and hlts2 and removed request for a team July 10, 2023 08:37
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak ykadowak merged commit 9079592 into main Jul 10, 2023
16 checks passed
@ykadowak ykadowak deleted the fix/ci/golangci-lint-too-slow branch July 10, 2023 12:27
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants