Propagate context to Search operation. #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlts2
changed the title
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
area/agent/core
size/M
type/bug
Deploying with
|
| Latest commit: |
f029ca3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4660257c.vald.pages.dev |
| Branch Preview URL: | https://bugfix-agent-add-search-cont.vald.pages.dev |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
- Coverage 31.13% 30.64% -0.50%
==========================================
Files 339 335 -4
Lines 32791 31291 -1500
==========================================
- Hits 10211 9589 -622
+ Misses 22131 21357 -774
+ Partials 449 345 -104
☔ View full report in Codecov by Sentry. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
hlts2
force-pushed
the
bugfix/agent/add-search-context
branch
from
d9fe927
to
f029ca3
Compare
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Fagent%2Fadd-search-context/fd62b98bc0bfe16c81319c743c8d1c4aac352eaa |
Profile Report
|
kmrmt
approved these changes
Jul 11, 2023
ykadowak
pushed a commit
that referenced
this pull request
Jul 25, 2023
* add search context to agent service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix test execution error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of ngt stateful test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WHAT
I fixed to propagate context to Search operation.
WHY
When Search operation is taking a long time, it cannot be interrupted because the Context is not propagated,
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: