Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor context #2121

Merged
merged 2 commits into from Jul 11, 2023
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 11, 2023

Description:

Refactor context canceling for more quick escape from processing

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: afae3dd
Status: ✅  Deploy successful!
Preview URL: https://fb87029d.vald.pages.dev
Branch Preview URL: https://refactor-lb-gateway-add-cont.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/lb-gateway/add-context-cancel-for-agent-search branch from 60f7326 to 163e4d9 Compare July 11, 2023 10:35
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the refactor/lb-gateway/add-context-cancel-for-agent-search branch from 163e4d9 to 4f88c5a Compare July 11, 2023 10:35
@kpango kpango requested review from kmrmt and hlts2 July 11, 2023 10:37
@github-actions github-actions bot removed the size/M label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 55.17% and project coverage change: +17.20 🎉

Comparison is base (e52eb4a) 31.13% compared to head (4f88c5a) 48.34%.

❗ Current head 4f88c5a differs from pull request most recent head afae3dd. Consider uploading reports for the commit afae3dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2121       +/-   ##
===========================================
+ Coverage   31.13%   48.34%   +17.20%     
===========================================
  Files         339      173      -166     
  Lines       32791     9042    -23749     
===========================================
- Hits        10211     4371     -5840     
+ Misses      22131     4545    -17586     
+ Partials      449      126      -323     
Impacted Files Coverage Δ
internal/errgroup/group.go 83.76% <55.17%> (-11.19%) ⬇️

... and 170 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango merged commit 5a28ee6 into main Jul 11, 2023
65 of 78 checks passed
@kpango kpango deleted the refactor/lb-gateway/add-context-cancel-for-agent-search branch July 11, 2023 16:55
ykadowak pushed a commit that referenced this pull request Jul 25, 2023
Signed-off-by: kpango <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants