Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] add cancelable search #2134

Closed
wants to merge 0 commits into from

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 18, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: +0.04 🎉

Comparison is base (6f5fb18) 31.09% compared to head (85314f6) 31.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
+ Coverage   31.09%   31.14%   +0.04%     
==========================================
  Files         339      339              
  Lines       32831    32828       -3     
==========================================
+ Hits        10210    10223      +13     
+ Misses      22169    22148      -21     
- Partials      452      457       +5     
Impacted Files Coverage Δ
internal/errors/ngt.go 60.86% <0.00%> (-9.14%) ⬇️
internal/test/goleak/goleak.go 0.00% <ø> (ø)
pkg/agent/core/ngt/handler/grpc/linear_search.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 35.80% <0.00%> (ø)
internal/core/algorithm/ngt/ngt.go 66.88% <61.11%> (+4.14%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the refactor/agent-ngt/add-cancelable-search branch from 3d23ad9 to db8e471 Compare July 18, 2023 12:46
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85314f6
Status: ✅  Deploy successful!
Preview URL: https://2ebc3f97.vald.pages.dev
Branch Preview URL: https://refactor-agent-ngt-add-cance.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/agent-ngt/add-cancelable-search branch from db8e471 to e8fdf7c Compare July 18, 2023 12:56
@kpango kpango changed the title [refactor] add cancelable search [DO NOT MERGE] add cancelable search Jul 18, 2023
@kpango kpango force-pushed the refactor/agent-ngt/add-cancelable-search branch 2 times, most recently from dfb64a0 to 23060cf Compare July 18, 2023 15:51
@vdaas vdaas deleted a comment from sonatype-lift bot Jul 18, 2023
@kpango kpango force-pushed the refactor/agent-ngt/add-cancelable-search branch from 23060cf to 85314f6 Compare July 18, 2023 16:03
@kpango kpango closed this Jul 20, 2023
@kpango kpango force-pushed the refactor/agent-ngt/add-cancelable-search branch from 85314f6 to 6f5fb18 Compare July 20, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants