Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp field to Object.Vector #2136

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Add timestamp field to Object.Vector #2136

merged 11 commits into from
Jul 26, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jul 24, 2023

Description:

This PR adds timestamp field to Object.Vector. This is a preparation for the index correction feature.

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9d6458e
Status: ✅  Deploy successful!
Preview URL: https://53683fbb.vald.pages.dev
Branch Preview URL: https://feature-add-timestamp.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 83.87% and project coverage change: +0.03% 🎉

Comparison is base (6f5fb18) 31.09% compared to head (37ce629) 31.12%.
Report is 2 commits behind head on main.

❗ Current head 37ce629 differs from pull request most recent head 9d6458e. Consider uploading reports for the commit 9d6458e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2136      +/-   ##
==========================================
+ Coverage   31.09%   31.12%   +0.03%     
==========================================
  Files         339      339              
  Lines       32831    32834       +3     
==========================================
+ Hits        10210    10221      +11     
+ Misses      22169    22161       -8     
  Partials      452      452              
Files Changed Coverage Δ
pkg/agent/core/ngt/service/ngt.go 36.83% <76.19%> (+1.02%) ⬆️
pkg/agent/core/ngt/handler/grpc/object.go 55.33% <100.00%> (+0.29%) ⬆️
pkg/agent/core/ngt/service/kvs/kvs.go 84.52% <100.00%> (ø)
pkg/agent/core/ngt/service/vqueue/queue.go 72.78% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added team/set SET team size/L and removed size/M labels Jul 24, 2023
@ykadowak ykadowak changed the title [WIP] Feature/add timestamp Add timestamp field to Object.Vector Jul 25, 2023
@ykadowak ykadowak requested review from a team, kevindiu and vankichi and removed request for a team July 25, 2023 01:54
@github-actions github-actions bot removed the size/L label Jul 25, 2023
@ykadowak ykadowak added this pull request to the merge queue Jul 26, 2023
@ykadowak ykadowak removed this pull request from the merge queue due to a manual request Jul 26, 2023
@ykadowak ykadowak merged commit f35756b into main Jul 26, 2023
75 checks passed
@ykadowak ykadowak deleted the feature/add-timestamp branch July 26, 2023 05:17
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants