Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Refactor github actions #2141

Merged
merged 139 commits into from Aug 28, 2023
Merged

[CI]: Refactor github actions #2141

merged 139 commits into from Aug 28, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jul 26, 2023

Description:

This PR contains the following changes

  • Add local action
    • dump-context
    • deploy-chaos-mesh
    • determine-docker-image-tag
    • notify-slack
    • scan-docker-image
    • setup-k3d
    • setup-e2e
    • setup-go
    • setup-helm
    • setup-yq
  • Add reusable workflow
    • docker image scan
    • docker image build
    • update protobuf
  • Improve E2E testing
    • Execute chaos test via k8s ingress (chaos test)
    • Enable Persistent volume to prevent index data loss (chaos test)
    • Improve gRPC client configurations for pod kill chaos scenario (chaos test)
    • If there are build images in PR when e2e testing, use them. If not, use nightly image (all e2e tests)
  • Fix build error of the NGT E2E test
  • Other refactors

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (bb04cb2) 31.13% compared to head (aeb816c) 31.17%.

❗ Current head aeb816c differs from pull request most recent head ae66bee. Consider uploading reports for the commit ae66bee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   31.13%   31.17%   +0.04%     
==========================================
  Files         339      339              
  Lines       32901    32920      +19     
==========================================
+ Hits        10243    10264      +21     
+ Misses      22202    22201       -1     
+ Partials      456      455       -1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae66bee
Status: ✅  Deploy successful!
Preview URL: https://63d26011.vald.pages.dev
Branch Preview URL: https://refactor-ci-update-action.vald.pages.dev

View logs

@hlts2 hlts2 force-pushed the refactor/ci/update-action branch from 94b43d0 to 51f5b0b Compare July 26, 2023 05:43
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 1, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 1, 2023

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@hlts2 hlts2 removed the team/sre SRE team label Aug 2, 2023
@hlts2
Copy link
Contributor Author

hlts2 commented Aug 2, 2023

/label team/sre

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

hlts2 and others added 20 commits August 28, 2023 09:55
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* e2e test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* reduce inserted vector size

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* reduce search by id count

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* enable ingress when running e2e-chaos test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* style: Format code with prettier and gofumpt

* change discovery duration for chaos test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* enable persistent volume for e2e chaos testing

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix pv access mode to prevent unsupported error

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* use make e2e/insert/search command

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* set workflow environment variable

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* add new environment variable for refactor

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix index replicas

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* update helth check duration for grpc client

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 merged commit af8d98b into main Aug 28, 2023
99 of 146 checks passed
@hlts2 hlts2 deleted the refactor/ci/update-action branch August 28, 2023 01:02
@hlts2 hlts2 mentioned this pull request Aug 28, 2023
2 tasks
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
@hlts2 hlts2 mentioned this pull request Sep 26, 2023
2 tasks
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants