Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate make command #2165

Merged
merged 2 commits into from Aug 31, 2023
Merged

Fix duplicate make command #2165

merged 2 commits into from Aug 31, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Aug 31, 2023

Description:

I fixed a duplicate make command declaration.

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested review from a team, kevindiu, kpango and vankichi and removed request for a team and kevindiu August 31, 2023 06:53
@github-actions github-actions bot added team/sre SRE team area/makefile size/S type/bug Something isn't working labels Aug 31, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 31, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f1b4cc
Status: ✅  Deploy successful!
Preview URL: https://ebc77a87.vald.pages.dev
Branch Preview URL: https://bugfix-makefile-e2e-command.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi merged commit ac21880 into main Aug 31, 2023
23 checks passed
@vankichi vankichi deleted the bugfix/makefile/e2e-command branch August 31, 2023 07:18
kpango pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
fix

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
Signed-off-by: kpango <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants