Enable ingress resource in the getStarted document #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
bc00927
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fae19bc5.vald.pages.dev |
| Branch Preview URL: | https://feature-docs-ingress-example.vald.pages.dev |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
hlts2
commented
Oct 17, 2023
| ``` | ||
|
|
||
| </details> | ||
| - Remove indexed 400 training datasets from the Vald agent. |
There was a problem hiding this comment.
📝 I fixed the indentation because it is broken.
👉 https://vald.vdaas.org/docs/tutorial/vald-agent-standalone-on-k8s/
hlts2
commented
Oct 17, 2023
| @@ -236,7 +236,7 @@ This chapter uses [NGT](https://github.com/yahoojapan/ngt) as Vald Agent to perf | |||
| ```go | |||
| ctx := context.Background() | |||
|
|
|||
| conn, err := grpc.DialContext(ctx, grpcServerAddr, grpc.WithInsecure()) | |||
| conn, err := grpc.DialContext(ctx, grpcServerAddr, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
There was a problem hiding this comment.
Because WithInsecure is deprecated, I fixed it to use the WithTransportCredentials .
hlts2
requested review from
a team,
kpango and
vankichi
and removed request for
a team
hlts2
commented
Oct 17, 2023
| @@ -284,21 +284,23 @@ This chapter uses [NGT](https://github.com/yahoojapan/ngt) as Vald Agent to perf | |||
|
|
|||
| </details> | |||
|
|
|||
| - [Optional] Indexing manually instead of waiting for auto indexing | |||
| - [Optional] Indexing manually instead of waiting for auto indexing. | |||
There was a problem hiding this comment.
📝 I fixed the indentation because it is broken.
👉 https://vald.vdaas.org/docs/tutorial/vald-agent-standalone-on-k8s/
vankichi
approved these changes
Oct 17, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* fix: enable ingress resource in the getStarted document and refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: indent bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in ac6ee52 according to the output from Gofumpt and Prettier. Details: #2211 * fix expand format bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: broken expand Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: new line for visibility Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains the following changes.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: