Add index correction document #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
e9f5ecd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c4aeafe.vald.pages.dev |
| Branch Preview URL: | https://feature-docs-index-correctio.vald.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hlts2
reviewed
Oct 25, 2023
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
kpango
reviewed
Oct 26, 2023
docs/user-guides/index-correction.md
Outdated
| ## Important Notes | ||
|
|
||
| - Processing time | ||
| Under conditions of 10 million vectors and agent replica \*10, it takes about 10~20 minutes. The process is O(MN) where M is the number of vector items and N is the number of agent replicas. |
There was a problem hiding this comment.
I think O(MN) is worst case.
It would be better to describe about Index Replica.
hlts2
approved these changes
Oct 27, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Add index correction document * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in ffe071a according to the output from Gofumpt and Prettier. Details: #2217 * Update docs/user-guides/index-correction.md Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com> * Update notes on processing time --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: