Add document for RemoveByTimestamp RPC #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
3996a08
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f9e1797.vald.pages.dev |
| Branch Preview URL: | https://documentation-docs-add-rpc.vald.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hlts2
requested review from
a team,
vankichi and
ykadowak
and removed request for
a team
ykadowak
previously approved these changes
Nov 21, 2023
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
ykadowak
previously approved these changes
Nov 22, 2023
hlts2
commented
Nov 24, 2023
ykadowak
approved these changes
Nov 24, 2023
vankichi
approved these changes
Nov 24, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* feat: add document for RemoveByTimestamp rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add comment to enum value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 29b94da according to the output from Gofumpt and Prettier. Details: #2238 * feat: add notice section to removeByTimestamp arpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in cd02e4f according to the output from Gofumpt and Prettier. Details: #2238 * Update docs/api/remove.md --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I added RemoveByTimestamp RPC previously, but the documentation was not included, so I added it.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: