Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e job for index managemt job #2239

Merged
merged 16 commits into from Dec 7, 2023
Merged

Add e2e job for index managemt job #2239

merged 16 commits into from Dec 7, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Nov 22, 2023

Description:

WHY

There is no e2e job for the index management jobs, so I added it to this PR.

  • E2E test using an index management job.

For testing using the index management job, the index manager is disabled.
Therefore, the indexing operations are performed by index management jobs.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

This commit fixes the style issues introduced in c20df9a according to the output
from Gofumpt and Prettier.

Details: #2239
Copy link

cloudflare-pages bot commented Nov 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fdfc938
Status: ✅  Deploy successful!
Preview URL: https://89e8211d.vald.pages.dev
Branch Preview URL: https://ci-workflow-e2e-job.vald.pages.dev

View logs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
ykadowak
ykadowak previously approved these changes Nov 28, 2023
@hlts2 hlts2 requested a review from ykadowak December 7, 2023 07:15
Copy link
Contributor

github-actions bot commented Dec 7, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@vankichi vankichi merged commit f725e71 into main Dec 7, 2023
139 of 142 checks passed
@vankichi vankichi deleted the ci/workflow/e2e-job branch December 7, 2023 07:59
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
* feat: add stream crud e2e for index creation job

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in c20df9a according to the output
from Gofumpt and Prettier.

Details: #2239

* fix: change values file name

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: change target name

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: add deploy command for creation job and save job

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: bugfix target image specification

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* feat: add e2e chaos test under index management jobs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: make format

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: verify save job

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted e2e chaos under index management job

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: deleted unnecessary id

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants