Revert vtpool for ResourceExhausted problem #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ### Help | ||
|
|
||
| Provides links to documentation or for performing an out of band action. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Did you mean “out-of-band”? (OUT_OF_PLACE[1])
Suggestions: out-of-band
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/OUT_OF_PLACE?lang=en-US&subId=1
Category: PUNCTUATION
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2255 +/- ##
==========================================
- Coverage 30.50% 30.42% -0.09%
==========================================
Files 362 362
Lines 35376 35443 +67
==========================================
- Hits 10792 10784 -8
- Misses 24073 24146 +73
- Partials 511 513 +2 ☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
84c3efc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e86e1d18.vald.pages.dev |
| Branch Preview URL: | https://revert-vtpool.vald.pages.dev |
kpango
force-pushed
the
revert/vtpool
branch
2 times, most recently
from
44eab63
to
2d2d961
Compare
Signed-off-by: kpango <kpango@vdaas.org>
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/revert%2Fvtpool/600004d367291ab3dc80a2c509528fd425535788 |
Profile Report
|
ykadowak
approved these changes
Dec 1, 2023
ykadowak
changed the title
vankichi
approved these changes
Dec 1, 2023
Merged
ykadowak
added a commit
that referenced
this pull request
Dec 4, 2023
* revert vtpool Signed-off-by: kpango <kpango@vdaas.org> * Fix documentation --------- Signed-off-by: kpango <kpango@vdaas.org> Co-authored-by: ykadowak <yusuke.kadowaki.1231@gmail.com>
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* revert vtpool Signed-off-by: kpango <kpango@vdaas.org> * Fix documentation --------- Signed-off-by: kpango <kpango@vdaas.org> Co-authored-by: ykadowak <yusuke.kadowaki.1231@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts #2173 because it contained a regression that caused
RESOURCE_EXHAUSTEDerror when upserting from the Python Client.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: