Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svc discoverer for readreplica svc #2263

Merged
merged 30 commits into from Dec 18, 2023
Merged

Add svc discoverer for readreplica svc #2263

merged 30 commits into from Dec 18, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Dec 7, 2023 •
edited

Description:

This PR

1. Adds internal/k8s/readreplica/svc to reconcile readreplica svc resource

  1. Adds internal/k8s/svc to reconcile svc resources
  2. Updates discoverer to collect readreplica svc addrs and replica id by using the reconciler

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2023

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

github-actions[bot]
github-actions bot reviewed Dec 7, 2023
View reviewed changes
apis/docs/v1/docs.md Outdated Show resolved Hide resolved
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Dec 7, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5de93d
Status: ✅  Deploy successful!
Preview URL: https://331d7b79.vald.pages.dev
Branch Preview URL: https://feature-discoverer-svc.vald.pages.dev

View logs

github-actions[bot]
github-actions bot reviewed Dec 7, 2023
View reviewed changes
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/k8s/readreplica/svc/svc.go Outdated Show resolved Hide resolved
internal/config/discoverer.go Outdated Show resolved Hide resolved
pkg/discoverer/k8s/service/discover.go Outdated Show resolved Hide resolved
pkg/discoverer/k8s/service/option.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited

Codecov Report

Attention: 272 lines in your changes are missing coverage. Please review.

Comparison is base (84d2ab1) 30.00% compared to head (b5de93d) 29.78%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/discoverer/k8s/handler/grpc/handler.go 0.00% 76 Missing ⚠️
internal/k8s/service/service.go 12.04% 73 Missing ⚠️
pkg/discoverer/k8s/service/discover.go 0.00% 50 Missing ⚠️
internal/k8s/service/option.go 0.00% 40 Missing ⚠️
internal/config/discoverer.go 6.25% 28 Missing and 2 partials ⚠️
internal/errors/discoverer.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   30.00%   29.78%   -0.23%     
==========================================
  Files         370      372       +2     
  Lines       36089    36372     +283     
==========================================
+ Hits        10829    10833       +4     
- Misses      24747    25024     +277     
- Partials      513      515       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L and removed team/set SET team size/L labels Dec 7, 2023
@github-actions github-actions bot added size/L and removed size/L labels Dec 7, 2023
ykadowak and others added 2 commits December 13, 2023 08:56
@ykadowak
rename rrsvcs to services
a16b1e5
@deepsource-autofix
style: format code with Gofumpt and Prettier
38c9af6 
This commit fixes the style issues introduced in a16b1e5 according to the output
from Gofumpt and Prettier.

Details: #2263
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

vankichi
vankichi reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
I would appreciate it if you added a comment for each Global value/function that you implemented.
e.g.
- internal/k8s/service/... files
- pkg files

vankichi
vankichi approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kpango
kpango approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 9b6217b into main Dec 18, 2023
114 of 117 checks passed
@kpango kpango deleted the feature/discoverer/svc branch December 18, 2023 02:27
@vankichi vankichi mentioned this pull request Dec 19, 2023
Merged
This was referenced Jan 28, 2024
Open
Open
Open
Open
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@kpango kpango kpango approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/discoverer area/gateway/filter area/gateway/lb area/helm area/internal area/manager/index priority/medium size/XXL team/set SET team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ykadowak @vdaas-ci @vankichi @kpango