Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed log for readreplica rotator #2281

Merged
merged 4 commits into from Dec 27, 2023
Merged

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Dec 26, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (8dc67ee) 30.00% compared to head (3d393ab) 30.00%.

Files Patch % Lines
...kg/index/job/readreplica/rotate/service/rotator.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   30.00%   30.00%   -0.01%     
==========================================
  Files         371      371              
  Lines       36115    36126      +11     
==========================================
+ Hits        10837    10838       +1     
- Misses      24766    24776      +10     
  Partials      512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykadowak ykadowak changed the title [WIP] Fix rotator cannot rotate readreplica sometimes Add detailed log for readreplica Dec 27, 2023
@ykadowak ykadowak marked this pull request as ready for review December 27, 2023 02:24
@ykadowak ykadowak changed the title Add detailed log for readreplica Add detailed log for readreplica rotator Dec 27, 2023
vankichi
vankichi previously approved these changes Dec 27, 2023
Copy link

cloudflare-pages bot commented Dec 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d393ab
Status: ✅  Deploy successful!
Preview URL: https://56134459.vald.pages.dev
Branch Preview URL: https://fix-rotator-inhouse-k8s.vald.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants