Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner reference to the resources made by rotator to delete them when read replica resources are deleted #2287

Merged
merged 5 commits into from Jan 10, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jan 5, 2024

Description:

The resources created by rotator will not be removed with helm delete as is, so this PR attaches a reference with the read replica's Deployment as the owner.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jan 5, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak changed the title Feature/readreplica/add ownerref [WIP] Feature/readreplica/add ownerref Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (a4459f1) 29.99% compared to head (8586c1a) 29.98%.
Report is 3 commits behind head on main.

Files Patch % Lines
...kg/index/job/readreplica/rotate/service/rotator.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
- Coverage   29.99%   29.98%   -0.01%     
==========================================
  Files         371      371              
  Lines       36126    36152      +26     
==========================================
+ Hits        10835    10840       +5     
- Misses      24777    24799      +22     
+ Partials      514      513       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-pages bot commented Jan 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8586c1a
Status: ✅  Deploy successful!
Preview URL: https://13eb6e56.vald.pages.dev
Branch Preview URL: https://feature-readreplica-add-owne.vald.pages.dev

View logs

@ykadowak ykadowak marked this pull request as ready for review January 5, 2024 08:01
@ykadowak ykadowak changed the title [WIP] Feature/readreplica/add ownerref Add owner reference to the resources made by rotator to delete them when read replica resources are deleted Jan 5, 2024
@ykadowak ykadowak requested review from a team, vankichi and datelier and removed request for a team January 10, 2024 05:37
@ykadowak ykadowak merged commit 3ef2f35 into main Jan 10, 2024
47 of 50 checks passed
@ykadowak ykadowak deleted the feature/readreplica/add-ownerref branch January 10, 2024 05:59
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants