Change license/gen to skip symlink #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o become normal file. This commit adds a new function called `isSymlink` to check if a given path is a symbolic link. It also includes a corresponding test in the `main_test.go` file. This functionality will be useful for handling symbolic links in the codebase.
|
[CHATOPS:HELP] ChatOps commands.
|
ykadowak
changed the title
Deploying with
|
| Latest commit: |
3b53c6c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dbdcb710.vald.pages.dev |
| Branch Preview URL: | https://fix-license-ignore-symlink.vald.pages.dev |
ykadowak
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
kmrmt
approved these changes
Jan 10, 2024
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a logic to license/gen to skip symlink. This is required to avoid symlink files like
values.yamlin vald-readreplica to become normal file onmake format.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: