Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deeepsource errors #2299

Merged
merged 5 commits into from Jan 21, 2024
Merged

Fix deeepsource errors #2299

merged 5 commits into from Jan 21, 2024

Conversation

ykadowak
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@ykadowak ykadowak marked this pull request as ready for review January 19, 2024 07:29
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea6a157) 30.15% compared to head (c79952e) 30.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   30.15%   30.14%   -0.02%     
==========================================
  Files         389      389              
  Lines       40826    40826              
==========================================
- Hits        12313    12308       -5     
- Misses      27861    27866       +5     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-pages bot commented Jan 19, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c79952e
Status: ✅  Deploy successful!
Preview URL: https://cf33289b.vald.pages.dev
Branch Preview URL: https://fix-readreplica-deeepsource.vald.pages.dev

View logs

@github-actions github-actions bot added size/M and removed size/S labels Jan 19, 2024
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak ykadowak merged commit e25aba1 into main Jan 21, 2024
39 of 41 checks passed
@ykadowak ykadowak deleted the fix/readreplica/deeepsource branch January 21, 2024 11:01
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants