Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix grpc ip direct connection status check #2316

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Feb 1, 2024

Description:

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 1, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the bugfix/internal-grpc/ip-connection-idle-removal-problem branch from 43eb9f5 to a596c5f Compare February 1, 2024 08:10
Copy link

cloudflare-pages bot commented Feb 1, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29b6ff2
Status: ✅  Deploy successful!
Preview URL: https://cba62ec5.vald.pages.dev
Branch Preview URL: https://bugfix-internal-grpc-ip-conn.vald.pages.dev

View logs

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (52ca812) 30.30% compared to head (29b6ff2) 30.31%.
Report is 4 commits behind head on main.

Files Patch % Lines
internal/net/grpc/pool/pool.go 0.00% 17 Missing ⚠️
hack/license/gen/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
+ Coverage   30.30%   30.31%   +0.01%     
==========================================
  Files         391      391              
  Lines       40945    40953       +8     
==========================================
+ Hits        12407    12415       +8     
- Misses      27875    27876       +1     
+ Partials      663      662       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vankichi
vankichi previously approved these changes Feb 1, 2024
Update internal/net/grpc/pool/pool.go

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the bugfix/internal-grpc/ip-connection-idle-removal-problem branch from 87bda2f to 4f2fd35 Compare February 1, 2024 08:19
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 1, 2024

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango requested review from vankichi and hlts2 February 2, 2024 04:30
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@vankichi vankichi merged commit adf1b61 into main Feb 5, 2024
120 of 122 checks passed
@vankichi vankichi deleted the bugfix/internal-grpc/ip-connection-idle-removal-problem branch February 5, 2024 02:08
@hlts2 hlts2 mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants