New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] gcc environment for ARM #2334

Merged

kpango merged 1 commit into main from bugfix/docker/gcc-environment-for-arm

Feb 15, 2024

+397 −454

Collaborator

kpango commented Feb 8, 2024

Description

Related Issue

Versions

Go Version: 1.22.0
Docker Version: 20.10.8
Kubernetes Version: v1.29.1
NGT Version: 2.1.6

Checklist

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Collaborator

vdaas-ci commented Feb 8, 2024

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions bot added type/ci size/M type/bug priority/medium labels

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch from 764e457 to 7c7ea29 Compare

February 8, 2024 07:09

cloudflare-pages bot commented Feb 8, 2024 •

edited

Deploying with Cloudflare Pages

Latest commit:	`92d3966`
Status:	✅ Deploy successful!
Preview URL:	https://427d80b7.vald.pages.dev
Branch Preview URL:	https://bugfix-docker-gcc-environmen.vald.pages.dev

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 2 times, most recently from 02e647a to 9856ee4 Compare

February 8, 2024 07:17

github-actions bot added the area/makefile label

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch from 9856ee4 to 1572340 Compare

February 8, 2024 07:24

hlts2 previously approved these changes

View reviewed changes

Contributor

hlts2 left a comment

LGTM!

kpango dismissed hlts2’s stale review via

c5d0932

February 8, 2024 08:05

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 2 times, most recently from c5d0932 to 49d31e6 Compare

February 8, 2024 08:21

github-actions bot added size/L and removed size/M labels

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 4 times, most recently from 5c688f9 to e52428b Compare

February 8, 2024 09:35

hlts2 self-assigned this

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch from e52428b to 6f65704 Compare

February 8, 2024 09:50

ykadowak reviewed

View reviewed changes

dockers/agent/core/faiss/Dockerfile Outdated Show resolved Hide resolved

dockers/tools/cli/loadtest/Dockerfile Outdated Show resolved Hide resolved

kmrmt previously approved these changes

View reviewed changes

kpango dismissed kmrmt’s stale review via

64e7bde

February 13, 2024 05:12

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 3 times, most recently from e353001 to 605fc10 Compare

February 13, 2024 05:12

hlts2 requested a review from ykadowak

February 13, 2024 08:30

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 2 times, most recently from b239793 to d6f06c1 Compare

February 14, 2024 07:59

github-actions bot added the size/XL label

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch from d6f06c1 to f00f2b2 Compare

February 14, 2024 07:59

github-actions bot removed the size/L label

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 7 times, most recently from dc2d4fc to c771290 Compare

February 14, 2024 09:55

github-actions bot reviewed

View reviewed changes

dockers/agent/sidecar/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/discoverer/k8s/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/gateway/filter/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/gateway/lb/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/gateway/mirror/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  go mod download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/index/job/correction/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/index/job/creation/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/index/job/readreplica/rotate/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/index/job/save/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

dockers/manager/index/Dockerfile Outdated

-              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${TARGETARCH}" \
-                  --mount=type=cache,target="${HOME}/.cache/go-build",id="go-build-${TARGETARCH}" \
-                  make GOARCH=${TARGETARCH} GOOS=${TARGETOS} go/download
+              RUN --mount=type=cache,target="${GOPATH}/pkg",id="go-build-${BUILDARCH}" \

Contributor

github-actions bot Feb 14, 2024

📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch 5 times, most recently from 0214272 to 19d9ee2 Compare

February 15, 2024 02:25


          [bugfix] gcc environment for ARM

92d3966

Signed-off-by: kpango <kpango@vdaas.org>

kpango force-pushed the bugfix/docker/gcc-environment-for-arm branch from 19d9ee2 to 92d3966 Compare

February 15, 2024 02:25

kpango requested review from hlts2 and ykadowak

February 15, 2024 03:03

ykadowak approved these changes

View reviewed changes

hlts2 approved these changes

View reviewed changes

Contributor

hlts2 left a comment

LGTM!

kpango merged commit 16fb09f into main

146 checks passed

kpango deleted the bugfix/docker/gcc-environment-for-arm branch

February 15, 2024 04:26

This was referenced Feb 15, 2024

[patch] Release v1.7.11 #2355

Merged

[patch] Release v1.7.11 #2358

Merged

This was referenced Mar 1, 2024

Monthly review time metrics report: 2024-02-01..2024-02-29 ykadowak/actions-test#11

Closed

Monthly review time metrics report: 2024-02-01..2024-02-29 #2429

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment