Revert dev Dockerfile to use official devcontainer image #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
ykadowak
changed the title
ykadowak
force-pushed
the
fix/devcontainer/baseimage
branch
from
728f12d
to
d59583c
Compare
Deploying with
|
| Latest commit: |
dac10af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c9866737.vald.pages.dev |
| Branch Preview URL: | https://fix-devcontainer-baseimage.vald.pages.dev |
ykadowak
force-pushed
the
fix/devcontainer/baseimage
branch
8 times, most recently
from
3a3d0e2
to
b0f1a42
Compare
ykadowak
force-pushed
the
fix/devcontainer/baseimage
branch
from
b0f1a42
to
6c00bdd
Compare
ykadowak
changed the title
ykadowak
requested review from
a team,
kpango and
datelier
and removed request for
a team and
kpango
vankichi
approved these changes
Feb 9, 2024
kpango
approved these changes
Feb 9, 2024
This was referenced Feb 15, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current nightly devcontainer cannot be opened with vscode devcontainer extension. This PR fixes the issue.
Related Issue
Versions
Checklist
Special notes for your reviewer
I don't know why it's trying to import buildcahe and fail when there is no buildcache because it's the first try. But should be fine in the main branch. Also it should not be a big problem since it succeeds to publish image anyway.
https://github.com/vdaas/vald/actions/runs/7826490855/job/21368714853?pr=2335#step:9:5209