Backport PR #2305 to release/v1.7 for Add rotate-all option to rotator #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add rotate-all option to rotator * Fix linter warnings * Make it possible to choose multiple rotation target * Add tests for parseReplicaID * Add tests for parseReplicaID * Hide testify in internal * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in dd84674 according to the output from Gofumpt and Prettier. Details: #2305 * Apply format * Lint * Lint --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Deploying with
|
| Latest commit: |
535f7b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aeeef060.vald.pages.dev |
| Branch Preview URL: | https://backport-release-v1-7-featur-quw7.vald.pages.dev |
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v1.7 #2393 +/- ##
===============================================
Coverage ? 18.71%
===============================================
Files ? 549
Lines ? 73865
Branches ? 0
===============================================
Hits ? 13826
Misses ? 59299
Partials ? 740 ☔ View full report in Codecov by Sentry. |
ykadowak
deleted the
backport/release/v1.7/feature/rotator/add-all-option
branch
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a feature for the rotator to rotate all the read replica agent when
TARGET_REPLICA_ID=rotate-allis specified. This is mainly useful for development purpose.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: