Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] update k8s dependencies #349

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 25, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

update dependencies
controller-runtime version to v0.6.0
apimachinery v0.18.2

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.2
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.10.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango kpango requested review from rinx and vankichi April 25, 2020 05:01
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     [patch] update k8s dependencies

Powered by Pull Assistant. Last update 4dc0bf9 ... 4dc0bf9. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #349 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #349      +/-   ##
=========================================
+ Coverage    8.02%   8.12%   +0.09%     
=========================================
  Files         341     327      -14     
  Lines       17904   17670     -234     
=========================================
- Hits         1437    1435       -2     
+ Misses      16268   16037     -231     
+ Partials      199     198       -1     
Impacted Files Coverage Δ
internal/errors/compressor.go
internal/errors/worker.go
internal/errors/runtime.go
internal/errors/cassandra.go
internal/errors/tensorflow.go
internal/errors/ngt.go
internal/errors/http.go
internal/errors/vald.go
internal/errors/runner.go
internal/errors/observability.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5619b91...4dc0bf9. Read the comment docs.

@rinx
Copy link
Contributor

rinx commented Apr 25, 2020

LGTM
/approve

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by rinx.

@kpango kpango merged commit 0cdb9d7 into master Apr 25, 2020
@kpango kpango deleted the dependencies/go-module/update-k8s-dependencies branch April 25, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants