Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix protoc-gen-validate resolve failure #353

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 27, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

this PR resolves #352
protoc-gen-validate uses invalid version format in golang.
so I replaced it for go-modules

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     bugfix protoc-gen-validate resolve failure

Powered by Pull Assistant. Last update 8d12ecc ... 8d12ecc. Read the comment docs.

@rinx
Copy link
Contributor

rinx commented Apr 27, 2020

/approve

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by rinx.

@rinx rinx merged commit 643d226 into master Apr 27, 2020
@rinx rinx deleted the dependencies/go-module/fix-protoc-gen-validate-failure branch April 27, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot can't resolve your Go dependency files
3 participants