Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Document] Apply design template to flow diagram #441

Merged
merged 4 commits into from
Jun 8, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 5, 2020

Description:

This PR update the design of the flow diagram on the architecture document.

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 5, 2020

Score: 0.83

Best reviewed: commit by commit


Optimal code review plan

     apply template to flow diagram

     update flow description

     update images

     update diagrams

Powered by Pull Assistant. Last update c217100 ... 8da0be0. Read the comment docs.

@kevindiu kevindiu changed the title [Document] Apply design template to flow diagram [Draft] [Document] Apply design template to flow diagram Jun 5, 2020
hlts2
hlts2 previously approved these changes Jun 5, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor Author

kevindiu commented Jun 8, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 8, 2020

[REBASE] Rebase triggered by kevindiu for branch: documentation/update_arch_diagram

edit test: rinx

@vdaas-ci vdaas-ci force-pushed the documentation/update_arch_diagram branch from 8f3c548 to d7f262b Compare June 8, 2020 02:24
@kevindiu kevindiu marked this pull request as ready for review June 8, 2020 02:52
@kevindiu kevindiu changed the title [Draft] [Document] Apply design template to flow diagram [Document] Apply design template to flow diagram Jun 8, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/rebase
/approve

@vankichi vankichi merged commit 7e186db into master Jun 8, 2020
@vankichi vankichi deleted the documentation/update_arch_diagram branch June 8, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants