✨ Add options for AWS client #460

rinx · 2020-06-10T03:30:42Z

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

add options for AWS client of Agent-sidecar
- add disableSSL option
- and another options in aws.Config struct.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

Go Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-06-10T03:30:44Z

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

✨ Add enableSSL option for AWS client

...l/db/storage/blob/s3/option.go 75% changes removed in ✨ use bytef...

...age/blob/s3/session/session.go 67% changes removed in ✨ Add more ...

✨ use bytefmt to parse bytes unit

internal/config/blob.go 50% changes removed in ✨ Add more ...

🔊 Revise log level for s3 upload completed log

✨ Add more AWS SDK options

✅ Fix tests

🤖 Update license headers / Format go codes and yaml files

✅ Fix tests

🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update b11c24d ... 600bdff. Read the comment docs.

vdaas-ci · 2020-06-10T03:30:56Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2020-06-10T03:34:06Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

codecov · 2020-06-10T03:38:14Z

Codecov Report

Merging #460 into master will increase coverage by 0.01%.
The diff coverage is 7.80%.

@@            Coverage Diff            @@
##           master    #460      +/-   ##
=========================================
+ Coverage    7.87%   7.89%   +0.01%     
=========================================
  Files         388     392       +4     
  Lines       19943   20039      +96     
=========================================
+ Hits         1571    1582      +11     
- Misses      18148   18222      +74     
- Partials      224     235      +11

Impacted Files	Coverage Δ
internal/config/blob.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/s3/option.go	`4.54% <0.00%> (-2.13%)`	⬇️
internal/db/storage/blob/s3/s3.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/s3/session/session.go	`0.00% <0.00%> (ø)`
internal/db/storage/blob/s3/writer/writer.go	`0.00% <0.00%> (ø)`
internal/errors/unit.go	`0.00% <0.00%> (ø)`
internal/unit/unit.go	`0.00% <0.00%> (ø)`
pkg/agent/sidecar/service/storage/option.go	`9.52% <0.00%> (+2.85%)`	⬆️
pkg/agent/sidecar/service/storage/storage.go	`0.00% <0.00%> (ø)`
...ent/sidecar/usecase/initcontainer/initcontainer.go	`0.00% <0.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e810ac...600bdff. Read the comment docs.

internal/db/storage/blob/s3/option.go

vdaas-ci · 2020-06-10T07:14:44Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

internal/unit/unit.go

internal/db/storage/blob/s3/session/session.go

vdaas-ci · 2020-06-10T09:09:56Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2020-06-10T09:16:52Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx · 2020-06-10T09:30:22Z

/rebase
/format

vdaas-ci · 2020-06-10T09:31:00Z

[REBASE] Rebase triggered by rinx for branch: feature/agent-sidecar/add-aws-options

vdaas-ci · 2020-06-10T09:31:31Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2020-06-10T09:32:12Z

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

vdaas-ci · 2020-06-10T09:34:15Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx · 2020-06-10T09:55:30Z

/format

vdaas-ci · 2020-06-10T09:55:43Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2020-06-10T09:58:10Z

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

vdaas-ci · 2020-06-10T09:59:18Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

rinx · 2020-06-10T09:59:41Z

/rebase

kpango

LGTM

vdaas-ci · 2020-06-10T10:01:58Z

[REBASE] Rebase triggered by rinx for branch: feature/agent-sidecar/add-aws-options

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Signed-off-by: vdaas-ci <ci@vdaas.org>

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci · 2020-06-10T10:03:42Z

[WARNING] Changes in interal/config may require you to change Helm charts. Please check.

github-actions bot added area/agent/sidecar area/helm area/internal size/L type/feature New feature priority/medium labels Jun 10, 2020

rinx force-pushed the feature/agent-sidecar/add-aws-options branch from feee653 to 0448422 Compare June 10, 2020 03:33

kpango reviewed Jun 10, 2020

View reviewed changes

internal/db/storage/blob/s3/option.go Outdated Show resolved Hide resolved

rinx force-pushed the feature/agent-sidecar/add-aws-options branch from 0448422 to a9f0e74 Compare June 10, 2020 07:14

kpango reviewed Jun 10, 2020

View reviewed changes

internal/unit/unit.go Show resolved Hide resolved

kpango reviewed Jun 10, 2020

View reviewed changes

internal/db/storage/blob/s3/session/session.go Outdated Show resolved Hide resolved

github-actions bot added area/tools/cli/loadtest team/set SET team size/XXL and removed size/L labels Jun 10, 2020

vdaas-ci force-pushed the feature/agent-sidecar/add-aws-options branch from b69a977 to 9cbb127 Compare June 10, 2020 09:31

rinx marked this pull request as ready for review June 10, 2020 09:33

kpango previously approved these changes Jun 10, 2020

View reviewed changes

rinx and others added 8 commits June 10, 2020 10:02

✨ Add enableSSL option for AWS client

b11c24d

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

✨ use bytefmt to parse bytes unit

b4efc5c

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🔊 Revise log level for s3 upload completed log

7683894

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

✨ Add more AWS SDK options

4c5993e

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

✅ Fix tests

5d5db18

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🤖 Update license headers / Format go codes and yaml files

b4e5095

Signed-off-by: vdaas-ci <ci@vdaas.org>

✅ Fix tests

3f9b64b

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🤖 Update license headers / Format go codes and yaml files

600bdff

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci dismissed kpango’s stale review via 600bdff June 10, 2020 10:02

vdaas-ci force-pushed the feature/agent-sidecar/add-aws-options branch from 5c0e8fa to 600bdff Compare June 10, 2020 10:02

kpango merged commit dc8cf39 into master Jun 10, 2020

kpango deleted the feature/agent-sidecar/add-aws-options branch June 10, 2020 10:02

This was referenced Jun 11, 2020

WIP [patch] divide gateway #425

Closed

[patch] Refactor agent-sidecar: fix S3 reader & add backoff logic #467

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add options for AWS client #460

✨ Add options for AWS client #460

rinx commented Jun 10, 2020 •

edited

Loading

pull-assistant bot commented Jun 10, 2020 •

edited

Loading

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

codecov bot commented Jun 10, 2020 •

edited

Loading

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

kpango left a comment

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

✨ Add options for AWS client #460

✨ Add options for AWS client #460

Conversation

rinx commented Jun 10, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jun 10, 2020 • edited Loading

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

codecov bot commented Jun 10, 2020 • edited Loading

Codecov Report

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020

kpango left a comment

Choose a reason for hiding this comment

vdaas-ci commented Jun 10, 2020

vdaas-ci commented Jun 10, 2020

rinx commented Jun 10, 2020 •

edited

Loading

pull-assistant bot commented Jun 10, 2020 •

edited

Loading

codecov bot commented Jun 10, 2020 •

edited

Loading