internal/db/storage/blob/s3: remove ctx from struct

[rinx]

Description:

• removed ctx from struct because of anti-pattern.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

• Go Version: 1.14.3
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.11.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     ♻️ Remove context from writer struct

     ✅ fix tests

     💚 Fix CI for agent-sidecar

Powered by Pull Assistant. Last update dcf528c ... e232f22. Read the comment docs.

[kpango]

LGTM

[codecov]

Codecov Report

Merging #473 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #473   +/-   ##
======================================
  Coverage    7.83%   7.83%           
======================================
  Files         396     396           
  Lines       20323   20322    -1     
======================================
  Hits         1593    1593           
+ Misses      18493   18492    -1     
  Partials      237     237           

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/writer/writer.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a41da...e232f22. Read the comment docs.