-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add internal/config/tls test #534
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
[WARNING:INTCFG] Changes in |
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=========================================
+ Coverage 9.10% 9.13% +0.03%
=========================================
Files 402 402
Lines 20831 20846 +15
=========================================
+ Hits 1896 1905 +9
- Misses 18681 18688 +7
+ Partials 254 253 -1
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/config-tls |
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
d49254b
to
c7dd0ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if len(w.want) != len(got) { | ||
return errors.Errorf("len(got) = %d, len(want) = %d", len(got), len(w.want)) | ||
} | ||
for i := range w.want { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮👍🏿
@@ -23,47 +23,6 @@ type Option func(*credentials) error | |||
|
|||
var ( | |||
defaultOpts = []Option{ | |||
WithTLSConfig(&tls.Config{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we move this block to tls.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid same pointer between want
and got
in test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/config-tls |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Description:
I added test of
internal/config/tls
.And also, I refactored
internal/tls
for testingRelated Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: