Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-sidecar] Add cancel hook for file watcher #535

Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 1, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Added cancel hook for file watcher.
agent-sidecar does not stop correctly when it receives SIGTERM without it.

made the default post_stop_timeout longer.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🐛 Add cancel hook for file watcher

Powered by Pull Assistant. Last update 0567c23 ... 0567c23. Read the comment docs.

if err != nil {
return err
}
defer func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci] reported by reviewdog 🐶
only one cuddle assignment allowed before defer statement (wsl)

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #535 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #535      +/-   ##
=========================================
- Coverage    9.10%   9.09%   -0.01%     
=========================================
  Files         402     402              
  Lines       20831   20837       +6     
=========================================
  Hits         1896    1896              
- Misses      18681   18687       +6     
  Partials      254     254              
Impacted Files Coverage Δ
pkg/agent/sidecar/service/observer/observer.go 0.00% <0.00%> (ø)
pkg/agent/sidecar/service/observer/option.go 8.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c0eab...0567c23. Read the comment docs.

@rinx
Copy link
Contributor Author

rinx commented Jul 2, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 2, 2020

[REBASE] Rebase triggered by rinx for branch: bugfix/agent-sidecar/add-cancel-hook-for-internal-file-watch

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the bugfix/agent-sidecar/add-cancel-hook-for-internal-file-watch branch from 1eac014 to 0567c23 Compare July 2, 2020 00:38
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 2, 2020

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit c37b9dd into master Jul 2, 2020
@kpango kpango deleted the bugfix/agent-sidecar/add-cancel-hook-for-internal-file-watch branch July 2, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants