-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug singleflight test #547
Bug singleflight test #547
Conversation
Best reviewed: commit by commit
|
/rebase |
Codecov Report
@@ Coverage Diff @@
## test/internal/singleflight #547 +/- ##
============================================================
Coverage ? 9.39%
============================================================
Files ? 402
Lines ? 20859
Branches ? 0
============================================================
Hits ? 1960
Misses ? 18646
Partials ? 253 Continue to review full report at Codecov.
|
[REBASE] Rebase triggered by vankichi for branch: test/internal/improve_singleflight_test |
98f5cd6
to
7040107
Compare
[REBASE] Failed to rebase. |
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/improve_singleflight_test |
[REBASE] Failed to rebase. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
8d982a0
to
6b1ef79
Compare
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: comment out Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete unncessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* fix: test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: comment out Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete unncessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* fix: test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: comment out Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete unncessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
* ✅ add internal/singleflight test Signed-off-by: vankichi <kyukawa315@gmail.com> * Bug singleflight test (#547) * fix: test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: comment out Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete unncessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * ♻️ fix Signed-off-by: vankichi <kyukawa315@gmail.com> * ♻️ fix Signed-off-by: vankichi <kyukawa315@gmail.com> * ♻️ fix Signed-off-by: vankichi <kyukawa315@gmail.com> Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com
Description:
I fix the bug of singleflight pacakge test.
this code's coverage is 100%.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: