Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug singleflight test #547

Merged

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jul 6, 2020

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I fix the bug of singleflight pacakge test.
this code's coverage is 100%.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 6, 2020

Score: 0.73

Best reviewed: commit by commit


Optimal code review plan

     fix: test case

     fix: comment out

     fix: delete unncessary code

Powered by Pull Assistant. Last update adc9e6d ... 8b526b3. Read the comment docs.

@vankichi
Copy link
Contributor

vankichi commented Jul 6, 2020

/rebase

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (test/internal/singleflight@7040107). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             test/internal/singleflight    #547   +/-   ##
============================================================
  Coverage                              ?   9.39%           
============================================================
  Files                                 ?     402           
  Lines                                 ?   20859           
  Branches                              ?       0           
============================================================
  Hits                                  ?    1960           
  Misses                                ?   18646           
  Partials                              ?     253           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7040107...8b526b3. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/improve_singleflight_test

@vdaas-ci vdaas-ci force-pushed the test/internal/singleflight branch from 98f5cd6 to 7040107 Compare July 6, 2020 00:53
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Failed to rebase.

@vankichi
Copy link
Contributor

vankichi commented Jul 6, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/improve_singleflight_test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Failed to rebase.

hlts2 added 2 commits July 6, 2020 10:14
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 force-pushed the test/internal/improve_singleflight_test branch from 8d982a0 to 6b1ef79 Compare July 6, 2020 01:15
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 2f9c18a into test/internal/singleflight Jul 6, 2020
@vankichi vankichi deleted the test/internal/improve_singleflight_test branch July 6, 2020 02:48
vdaas-ci pushed a commit that referenced this pull request Jul 6, 2020
* fix: test case

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: comment out

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: delete unncessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vdaas-ci pushed a commit that referenced this pull request Jul 6, 2020
* fix: test case

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: comment out

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: delete unncessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vdaas-ci pushed a commit that referenced this pull request Jul 7, 2020
* fix: test case

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: comment out

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: delete unncessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vankichi added a commit that referenced this pull request Jul 7, 2020
* ✅ add internal/singleflight test

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Bug singleflight test (#547)

* fix: test case

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: comment out

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: delete unncessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* ♻️ fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

* ♻️ fix

Signed-off-by: vankichi <kyukawa315@gmail.com>

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants