Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AVX2 to Requirements #686

Merged
merged 1 commit into from
Sep 14, 2020
Merged

add AVX2 to Requirements #686

merged 1 commit into from
Sep 14, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Sep 9, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Add "AVX2 instructions" to Requirements section.

Related Issue:

#685

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.1
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 9, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@pull-assistant
Copy link

pull-assistant bot commented Sep 9, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     📝 add AVX2 to Requirements section

Powered by Pull Assistant. Last update 14baf01 ... 14baf01. Read the comment docs.

kevindiu
kevindiu reviewed Sep 9, 2020
View reviewed changes
README.md

kubernetes 1.17~
- Kubernetes 1.17~
- AVX2 instructions (required by Vald Agent NGT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the following question.

  1. Does X86 supported?
  2. ARM CPU supported?
  3. Only AVX2 is required? other AVX instruction is required?
Suggested change
- AVX2 instructions (required by Vald Agent NGT)
- X64 CPU with AVX2 instructions set supported (required by Vald Agent NGT)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 and 2 ... currently, we don't provide docker images for these CPU architectures.
however, we are planning to provide docker images for each of them in the near future.

3 ... i'm not sure but maybe only AVX2 is needed. @kpango do you know about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW not sure if AVX is required or optional 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, AVX2 is required, but once the issue #687 is resolved, it becomes optional.

kpango
kpango previously approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Sep 14, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: documentation/add-avx2-to-requirements

@rinx @actions-user
📝 add AVX2 to Requirements section
14baf01 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentation/add-avx2-to-requirements branch from edfe83e to 14baf01 Compare September 14, 2020 03:22
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

vdaas-ci
vdaas-ci approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit 77f6d2b into master Sep 14, 2020
@kpango kpango deleted the documentation/add-avx2-to-requirements branch September 14, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@kpango kpango kpango left review comments

@vankichi vankichi Awaiting requested review from vankichi

@hlts2 hlts2 Awaiting requested review from hlts2

Assignees
No one assigned
Labels
priority/low size/S type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rinx @vdaas-ci @kpango @kevindiu