CI: Build multi-platform Docker images #727

rinx · 2020-09-25T04:15:05Z

Description:

use buildx for docker builds
build amd64 & arm64 images (nightly, tags)
publish to docker.io and ghcr.io

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-09-25T04:15:09Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

♻️ refactor Makefile

Makefile 67% changes removed in 💚 use in...

♻️ add TAG variable

✨ add docker buildx

♻️ use golang:xxx-buster image as base

🔥 remove some platforms

💚 fix CI build

🐳 remove armv7 because of cmake 3.16 bug

🐛 fix extldflags

💚 enable build cache

💚 add PACKAGE_USER, PACKAGE_TOKEN

🏷️ add labels

💚 use max mode build cache

🐳 multi-platform images for agent-sidecar

🐳 build NGT before copying .git dir

🐳 use buildx for base, ci-container, dev-container images

💚 use independent cache for vald-base

⚡ remove exporting cache layers for vald-base

🐳 build arm64 images for other images

Powered by Pull Assistant. Last update d682cf7 ... eea5545. Read the comment docs.

vdaas-ci · 2020-09-25T04:15:20Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

kpango · 2020-10-02T01:51:43Z

could you please write a description ?
I understand multi-platform buildx feature and CI's but I don't get about BASE_TAG resouns and others

rinx · 2020-10-02T01:54:59Z

introduced BASE_TAG because using 'latest' tag is a bad practice.

rinx · 2020-10-02T01:56:14Z

/rebase

vdaas-ci · 2020-10-02T01:56:50Z

[REBASE] Rebase triggered by rinx for branch: feature/ci/multi-platform-docker-images

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :green_heart: fix build Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :green_heart: fix platforms Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango

Others looks good to me

kpango · 2020-10-02T01:58:40Z

dockers/base/Dockerfile

-    && rm "go${GO_VERSION}.linux-amd64.tar.gz" \
-    && ln -s /opt/go/bin/go /usr/bin/ \
+COPY --from=golang /usr/local/go /opt/go
+RUN ln -s /opt/go/bin/go /usr/bin/ \


$GOROOT/bin includes multiple binary. it would be better to add $GOROOT/bin to $PATH

thanks. fixed

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango · 2020-10-02T02:11:07Z

dockers/base/Dockerfile

+COPY --from=golang /usr/local/go /opt/go
+RUN ln -s /opt/go/bin/go /usr/bin/ \


Suggested change

COPY --from=golang /usr/local/go /opt/go

RUN ln -s /opt/go/bin/go /usr/bin/ \

COPY --from=golang /usr/local/go ${GOROOT}

RUN ln -s ${GOROOT}/bin/go /usr/bin/ \

revised but it's different a little

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango · 2020-10-02T02:17:37Z

/rebase
/format
/approve

vdaas-ci · 2020-10-02T02:18:12Z

[REBASE] Rebase triggered by kpango for branch: feature/ci/multi-platform-docker-images

vdaas-ci · 2020-10-02T02:19:03Z

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

vdaas-ci

[APPROVED] This PR is approved by kpango.

rinx · 2020-10-02T02:26:45Z

I'm checking the failed CI build. please wait for a moment.

rinx · 2020-10-02T02:28:43Z

it failed on exporting layer phase because of 500 error of the registry. i've just restarted it.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions bot added area/makefile team/sre SRE team type/ci size/M type/feature New feature priority/medium labels Sep 25, 2020

rinx force-pushed the feature/ci/multi-platform-docker-images branch 4 times, most recently from 1789c41 to 75f5ff1 Compare September 25, 2020 09:43

github-actions bot added size/L and removed size/M labels Sep 28, 2020

rinx force-pushed the feature/ci/multi-platform-docker-images branch 7 times, most recently from 342d715 to e818805 Compare October 1, 2020 08:54

rinx added 5 commits October 2, 2020 01:56

♻️ refactor Makefile

6a71d5a

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

♻️ add TAG variable

2d5ab05

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

✨ add docker buildx

2905eca

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :green_heart: fix build Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :green_heart: fix platforms Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

♻️ use golang:xxx-buster image as base

cadd26b

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🔥 remove some platforms

00783bd

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

rinx added 10 commits October 2, 2020 01:56

🐳 build NGT before copying .git dir

98817de

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 use buildx for base, ci-container, dev-container images

3fdb165

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

💚 use independent cache for vald-base

0cdb3c5

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

⚡ remove exporting cache layers for vald-base

6e6749c

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 build arm64 images for other images

a9128de

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 remove useless arm images

9c3c508

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 use BASE_TAG arg

1a48cbe

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 fix build command for helm-operator

c751b20

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 fix build of dev-container

cd46067

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🎨 build image for amd64 only when PR builds

45c1faa

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci force-pushed the feature/ci/multi-platform-docker-images branch from e42034f to 45c1faa Compare October 2, 2020 01:56

rinx marked this pull request as ready for review October 2, 2020 01:57

rinx requested a review from kpango October 2, 2020 01:57

kpango requested changes Oct 2, 2020

View reviewed changes

🐳 revise PATH

9019b6c

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango reviewed Oct 2, 2020

View reviewed changes

🐳 revise base golang dirs

eb10d45

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango previously approved these changes Oct 2, 2020

View reviewed changes

vdaas-ci previously approved these changes Oct 2, 2020

View reviewed changes

💚 use --load options for vald-base build

ec8bf00

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

rinx dismissed stale reviews from vdaas-ci and kpango via ec8bf00 October 2, 2020 02:47

💚 use --push options for vald-base build

1122fd9

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango merged commit 0d5880f into master Oct 2, 2020

kpango deleted the feature/ci/multi-platform-docker-images branch October 2, 2020 05:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Build multi-platform Docker images #727

CI: Build multi-platform Docker images #727

rinx commented Sep 25, 2020 •

edited

Loading

pull-assistant bot commented Sep 25, 2020 •

edited

Loading

vdaas-ci commented Sep 25, 2020

kpango commented Oct 2, 2020

rinx commented Oct 2, 2020

rinx commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

kpango left a comment

kpango Oct 2, 2020

rinx Oct 2, 2020

kpango Oct 2, 2020

rinx Oct 2, 2020

kpango commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

vdaas-ci left a comment

rinx commented Oct 2, 2020

rinx commented Oct 2, 2020

		COPY --from=golang /usr/local/go /opt/go
		RUN ln -s /opt/go/bin/go /usr/bin/ \

CI: Build multi-platform Docker images #727

CI: Build multi-platform Docker images #727

Conversation

rinx commented Sep 25, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Sep 25, 2020 • edited Loading

vdaas-ci commented Sep 25, 2020

kpango commented Oct 2, 2020

rinx commented Oct 2, 2020

rinx commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

kpango left a comment

Choose a reason for hiding this comment

kpango Oct 2, 2020

Choose a reason for hiding this comment

rinx Oct 2, 2020

Choose a reason for hiding this comment

kpango Oct 2, 2020

Choose a reason for hiding this comment

rinx Oct 2, 2020

Choose a reason for hiding this comment

kpango commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

vdaas-ci commented Oct 2, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

rinx commented Oct 2, 2020

rinx commented Oct 2, 2020

rinx commented Sep 25, 2020 •

edited

Loading

pull-assistant bot commented Sep 25, 2020 •

edited

Loading