Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e-bench-agent CI to fail correctly #800

Merged
merged 5 commits into from
Oct 28, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Oct 27, 2020

Description:

This PR fixes e2e-bench-agent CI to fail correctly.
Includes updates for Makefiles.

Also this PR updates actions/checkout@v1 -> v2 for all workflows.
https://github.com/actions/checkout#checkout-v2

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #800 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   17.37%   17.42%   +0.04%     
==========================================
  Files         420      421       +1     
  Lines       19500    19554      +54     
==========================================
+ Hits         3389     3408      +19     
- Misses      15903    15931      +28     
- Partials      208      215       +7     
Impacted Files Coverage Δ
...enchmark/internal/starter/agent/core/ngt/option.go 0.00% <ø> (ø)
...benchmark/internal/starter/external/ngtd/option.go 0.00% <ø> (ø)
internal/db/storage/blob/s3/reader/reader.go 65.90% <0.00%> (-31.82%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (ø)
internal/net/net.go 85.18% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2c8bb...9b5c0ce. Read the comment docs.

@github-actions github-actions bot added the team/set SET team label Oct 27, 2020
@rinx rinx force-pushed the ci/e2e-bench-agent/fix-failing-bench-tests branch from 7f6269e to d830663 Compare October 27, 2020 08:29
@rinx rinx changed the title Fix failing e2e bench tests Fix e2e-bench-agent CI to fail correctly Oct 27, 2020
@rinx rinx marked this pull request as ready for review October 27, 2020 08:31
@rinx rinx requested review from hlts2, kmrmt and kpango October 27, 2020 08:31
kpango
kpango previously approved these changes Oct 27, 2020
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmrmt
kmrmt previously approved these changes Oct 28, 2020
Copy link
Contributor

@kmrmt kmrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Oct 28, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: ci/e2e-bench-agent/fix-failing-bench-tests

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from kmrmt and kpango via 9b5c0ce October 28, 2020 05:44
@vdaas-ci vdaas-ci force-pushed the ci/e2e-bench-agent/fix-failing-bench-tests branch from 5dcc292 to 9b5c0ce Compare October 28, 2020 05:44
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit baeb365 into master Oct 28, 2020
@kpango kpango deleted the ci/e2e-bench-agent/fix-failing-bench-tests branch October 28, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants