Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise kubelinter config / Add securityContext section to Helm chart #833

Merged
merged 5 commits into from
Jan 18, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Nov 12, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

  • revise kubelinter config
  • fix warns from kubelinter
    • Add securityContext section to the Helm Chart.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx rinx force-pushed the ci/kubelinter/revise-rule-and-fix-warns branch 2 times, most recently from 961d7b7 to aee65d4 Compare November 12, 2020 05:42
@rinx
Copy link
Contributor Author

rinx commented Nov 12, 2020

This PR may conflict with #826 (maybe charts/vald/values.yaml).so it is better to wait for it to merge into master.

kpango
kpango previously approved these changes Nov 12, 2020
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Nov 12, 2020

I think it's okay to merge before merge #826, I'll add same configuration into gateway/{lb, backup, meta}

@rinx
Copy link
Contributor Author

rinx commented Nov 12, 2020

Thanks for reviewing.
I don't want to make #826 larger more. so please merge #826 first.

@rinx rinx marked this pull request as draft November 17, 2020 01:43
@rinx rinx force-pushed the ci/kubelinter/revise-rule-and-fix-warns branch 3 times, most recently from 82a2c46 to e124223 Compare December 16, 2020 02:37
@rinx rinx force-pushed the ci/kubelinter/revise-rule-and-fix-warns branch 5 times, most recently from 5ba0765 to d3395f2 Compare December 24, 2020 02:36
@rinx rinx force-pushed the ci/kubelinter/revise-rule-and-fix-warns branch 3 times, most recently from 7c91c4b to 1b8b8a3 Compare January 12, 2021 02:19
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:pencil2: Fix typo

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:wrench: Add securityContext section to newly added componentes

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the ci/kubelinter/revise-rule-and-fix-warns branch from 1b8b8a3 to 6676151 Compare January 18, 2021 05:48
@rinx rinx changed the title revise kubelinter config revise kubelinter config / Add securityContext section to Helm chart Jan 18, 2021
@rinx rinx marked this pull request as ready for review January 18, 2021 05:51
@rinx rinx requested a review from kpango January 18, 2021 05:51
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 95dacd2 into master Jan 18, 2021
@kpango kpango deleted the ci/kubelinter/revise-rule-and-fix-warns branch January 18, 2021 07:00
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants