Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Grafana dashboards #940

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Update Grafana dashboards #940

merged 4 commits into from
Jan 21, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jan 20, 2021 •
edited
Loading

Description:

This PR is cherry-picked from #852.
Update Grafana dashboards.
NGT metrics are renamed.
Grafana Tempo and Loki manifests are included.

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #940 (62521c5) into master (efad135) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   16.00%   16.08%   +0.07%     
==========================================
  Files         475      475              
  Lines       23768    23754      -14     
==========================================
+ Hits         3805     3820      +15     
+ Misses      19718    19694      -24     
+ Partials      245      240       -5
Impacted Files Coverage Δ
...ternal/observability/metrics/agent/core/ngt/ngt.go 0.00% <0.00%> (ø)
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
pkg/meta/redis/usecase/meta.go 0.00% <0.00%> (ø)
pkg/gateway/vald/usecase/vald.go 0.00% <0.00%> (ø)
pkg/meta/cassandra/usecase/meta.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/usecase/agentd.go 0.00% <0.00%> (ø)
pkg/manager/index/usecase/indexer.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/usecase/discovered.go 0.00% <0.00%> (ø)
pkg/manager/backup/mysql/usecase/backupd.go 0.00% <0.00%> (ø)
pkg/agent/sidecar/usecase/sidecar/sidecar.go 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efad135...4c05ce7. Read the comment docs.

@rinx rinx force-pushed the refactor/observability/update-grafana-dashboards branch from e7de5e7 to da6c2e5 Compare January 21, 2021 02:55
@rinx rinx requested a review from kpango January 21, 2021 02:56
@rinx
🔧 Add loki & tempo k8s manifests
583e20e 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:wrench: update Grafana dashboards & Prometheus config

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:pencil2: Use same rule for task naming

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx
🚚 Rename NGT metrics names
d7d8bf7
@rinx
📄 Update license
64d6ea9 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the refactor/observability/update-grafana-dashboards branch from da6c2e5 to 64d6ea9 Compare January 21, 2021 03:54
kpango
kpango previously approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@rinx @kpango
Apply suggestions from code review
4c05ce7 
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
kpango
kpango approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit d4dcd05 into master Jan 21, 2021
@kpango kpango deleted the refactor/observability/update-grafana-dashboards branch January 21, 2021 05:29
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
Merged
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
area/internal area/makefile priority/low size/XXL team/sre SRE team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rinx @vdaas-ci @kpango