Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namespaced names for priorityclasses of new gateways #992

Merged
merged 1 commit into from Feb 9, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Feb 9, 2021

Description:

Revised the priorityclass names of new gateways

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 9, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@rinx
Copy link
Contributor Author

rinx commented Feb 9, 2021

/format
/rebase

@github-actions github-actions bot added size/S type/bug Something isn't working priority/medium labels Feb 9, 2021
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 9, 2021

[REBASE] Rebase triggered by rinx for branch: bugfix/helm-chart/new-gateways-priorityclass-names

@vdaas-ci vdaas-ci force-pushed the bugfix/helm-chart/new-gateways-priorityclass-names branch from d566e94 to ebb7b67 Compare February 9, 2021 02:30
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 9, 2021

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit ca55f25 into master Feb 9, 2021
@kpango kpango deleted the bugfix/helm-chart/new-gateways-priorityclass-names branch February 9, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants