Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for internal/errors/observability.go #993

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Feb 9, 2021

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added the test cases for internal/errors/net.go and comment.

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 9, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested a review from vankichi February 9, 2021 03:31
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #993 (a95ffee) into master (30b724d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
+ Coverage   14.48%   14.49%   +0.01%     
==========================================
  Files         494      494              
  Lines       28300    28300              
==========================================
+ Hits         4098     4102       +4     
+ Misses      23955    23951       -4     
  Partials      247      247              
Impacted Files Coverage Δ
internal/errors/observability.go 100.00% <100.00%> (+100.00%) ⬆️
internal/worker/worker.go 84.37% <0.00%> (+1.04%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5211e87...ad0e876. Read the comment docs.

@hlts2 hlts2 self-assigned this Feb 9, 2021
internal/errors/observability.go Outdated Show resolved Hide resolved
internal/errors/observability_test.go Outdated Show resolved Hide resolved
vankichi
vankichi previously approved these changes Feb 10, 2021
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-for-errors-observability

hlts2 and others added 3 commits February 12, 2021 02:04
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kevindiu.

@kevindiu kevindiu merged commit 9394142 into master Feb 15, 2021
@kevindiu kevindiu deleted the test/internal/add-test-for-errors-observability branch February 15, 2021 01:03
@vdaas-ci vdaas-ci mentioned this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants