Skip to content
This repository has been archived by the owner on May 15, 2022. It is now read-only.

Marginalia in Markdown were not transformed #1

Open
rschiang opened this issue Sep 6, 2014 · 4 comments
Open

Marginalia in Markdown were not transformed #1

rschiang opened this issue Sep 6, 2014 · 4 comments

Comments

@rschiang
Copy link

rschiang commented Sep 6, 2014

As a developer and law undergraduate, it's really nice to bump into a project dedicated to lawyers. 😃

A quick browse through chapter 2 would notice several margin headers not transformed and were left intact. Probably a misconfigured parser caused the issue?

@vdavez
Copy link
Owner

vdavez commented Sep 7, 2014

Thanks! It's great to hear that there are more developers who are interested in law. There is a great need for developers who understand the law, and perhaps an even greater need for lawyers who understand the Internet.

As for the marginalia bug, that's a good catch... At some point in the coming days/weeks, I'm planning on moving away from the standard bootstrap CSS and attempting to use better typography. Hopefully, I can get it to work then.

I hope you enjoy the book, and if there are thoughts about how to improve it, please contribute!

@daveloyall
Copy link

I noticed this is Chapter 2. Since the markup appears in the document about markup, I'd go so far as to remove those notes until they can be rendered properly.

Congrats on being featured on HackerNews.

@vdavez
Copy link
Owner

vdavez commented Sep 16, 2014

First off, thanks for the comment. When I got your email, it was the first indication that codingforlawyers was on HN. Somehow, the fact that I learned about it through a GitHub Issue validates so much of this project. So thanks.

Second, this is a difficult choice for me. The right thing is likely to get rid of it now. But, I'm having a hard time letting go of the idea that I'll have marginalia to help the readers along.

That said, you're right, and I'll take 'em out.

@compleatang
Copy link

Could always leave them in another branch...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants