Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses new emojis.json and fix encoding problems #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jbwzx
Copy link

@Jbwzx Jbwzx commented Mar 26, 2020

This pr:

  1. Adds all available emojis out there
  2. Fix problems with incorrectly encoded emojis e.g:

old emojis.json

    "emojiChar": "🎚",
    "emoji": "\uD83C\uDF9A", // <- wrong

new emojis.json

        "emojiChar": "🎚️",
        "emoji": "\uD83C\uDF9A\uFE0F", // <- correct

Notes:

  1. New db was rebuild using gemoji library database
  2. Old aliases are removed (I wanted to compare and add them, but have no time, sorry)
  3. Tested on Android 5 / 6 / 7 / 8 / 9 / 10 / R all good.

@vdurmont
Copy link
Owner

I really appreciate the effort! Thanks for working on this. I cannot review in github (the diff is too big and won't load) so I'll try to review later but it looks like it's going to take a looooong time.

I am worried about:

Old aliases are removed (I wanted to compare and add them, but have no time, sorry)

This breaks retrocompatibility. Was it really necessary?

@Jbwzx
Copy link
Author

Jbwzx commented Mar 30, 2020

Hey,
Thanks for a response.

If it does, I'll compare and add old aliases.

Will update in the next couple of days.

@alexgasparyan
Copy link

@Jbwzx Hi. It also seems like you have lost "supports_fitzpatrick": true in many occasions

@Jbwzx
Copy link
Author

Jbwzx commented Apr 1, 2020

@alexgasparyan just double checked, you're right. will fix alongside aliases. Thanks

@uburoiubu
Copy link

any updates on this one?

@MolotovCherry
Copy link

At the very least we can download the json for now and load it manually

@gdude2002
Copy link

Would be nice to get some updates on this, almost exactly a year later

@Jbwzx
Copy link
Author

Jbwzx commented May 25, 2021

@gdude2002 Funny enough, I've actually put it in my todo list last weekend. I'll try to sort it out in the following fortnight

@Jbwzx
Copy link
Author

Jbwzx commented May 25, 2021

@gdude2002 ready.

@vdurmont

  1. Gemoji lib reparsed -> Emoji Unicode v13 added
  2. Aliases merged between Emoji-Java and Gemoji
  3. Tags merged between Emoji-Java and Gemoji

and of course as mentioned year ago encoding issue fixed.

@thecatmonkey
Copy link

Hi

Our team would like to use this latest commits. Is there an ETA where we could get these changes merged?

Thanks

@Jbwzx
Copy link
Author

Jbwzx commented Jun 15, 2021

Hi

Our team would like to use this latest commits. Is there an ETA where we could get these changes merged?

Thanks

Hey.

Not sure re merge, but what we did with one of our commercial project is simply added lib as a submodule replacing reparsed lib file.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants