Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adoption in modularized Java 9 projects #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nictas
Copy link
Contributor

@nictas nictas commented Sep 2, 2020

Currently, this project can't be used in a modularized Java 9 (or greater) project, because it cannot be required as a module:

module foo {

    requires org.apache.commons.collections4;
    requires com.vdurmont.semver4j; // Does not compile!

}

The easiest way to solve this is to add an automatic module name as I've done in this PR. There's also another way that involves the creation of a module-info.java file, but it also requires the adoption of Java 9 in this project, which is unwise IMO.

More info here: https://blog.joda.org/2018/03/jpms-negative-benefits.html

@piotrooo
Copy link

This will be fixed in 2.1.0 in active copy of this lib: https://github.com/semver4j/semver4j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants