Enable adoption in modularized Java 9 projects #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this project can't be used in a modularized Java 9 (or greater) project, because it cannot be required as a module:
The easiest way to solve this is to add an automatic module name as I've done in this PR. There's also another way that involves the creation of a
module-info.java
file, but it also requires the adoption of Java 9 in this project, which is unwise IMO.More info here: https://blog.joda.org/2018/03/jpms-negative-benefits.html