Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autorotate timer messed up after pauseonhover #18

Closed
malnosna opened this issue Feb 9, 2015 · 5 comments
Closed

autorotate timer messed up after pauseonhover #18

malnosna opened this issue Feb 9, 2015 · 5 comments
Labels

Comments

@malnosna
Copy link

malnosna commented Feb 9, 2015

With auto-rotation, when you mouseover a tab (or main banner area), the rotation pauses, and when you mouseleave (move the mouse away), the rotation unpauses and continues after 1 second.

However, if you keep doing this mouseover and mouseleave over the tabs (or main banner area) continuously and rapidly, the timer will all be messed up and the rotation will no longer follow the set "delay", but rotate at a random time.

@vdw vdw added the bug label Feb 10, 2015
vdw pushed a commit that referenced this issue Feb 26, 2015
Issue #18
@vdw
Copy link
Owner

vdw commented Feb 26, 2015

Hi, the issue with the timer has been fixed at version 1.4.5, thanks.

@vdw vdw closed this as completed Feb 26, 2015
@malnosna
Copy link
Author

Hi, Thanks for the fix. However, I found that the problem still persists if I do the rapid mouseover/mouseleave BEFORE the first rotation happens. It can be replicated more easily if you set a higher delay. It seems to happen only when pauseonhover is true. In addition, pauseonhover also doesn't work on the first rotation.

@vdw vdw reopened this Feb 26, 2015
vdw pushed a commit that referenced this issue Feb 26, 2015
Issue #18 - comment
@vdw
Copy link
Owner

vdw commented Feb 26, 2015

Fixed at version 1.4.6.
;-)

@vdw vdw closed this as completed Feb 26, 2015
@malnosna
Copy link
Author

The timer issue is fixed, but pauseonhover still doesn't work on the very first rotation - hover on the very first slide/tab before it rotates to the second one. Only happens once after initialization.

@vdw vdw reopened this Feb 27, 2015
@vdw
Copy link
Owner

vdw commented Mar 2, 2015

At version 1.4.7 the rotation stops on the first tab.

@vdw vdw closed this as completed Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants