Unify return data format of document interface

vearch · Mar 28, 2024 · fee96a2 · fee96a2
1 parent a1b41aa
commit fee96a2
Show file tree

Hide file tree

Showing 12 changed files with 282 additions and 219 deletions.
diff --git a/internal/client/master_cache.go b/internal/client/master_cache.go
@@ -822,8 +822,6 @@ func (cliCache *clientCache) AliasByCache(ctx context.Context, alias_name string
 	}
 
 	err := cliCache.reloadAliasCache(ctx, false, alias_name)
-	vearchlog.LogErrNotNil(err)
-
 	if err != nil {
 		return nil, fmt.Errorf("alias_name:[%s] err:[%s]", alias_name,
 			vearchpb.NewError(vearchpb.ErrorEnum_ALIAS_NOT_EXIST, nil))

diff --git a/internal/proto/errors.proto b/internal/proto/errors.proto
@@ -83,6 +83,25 @@ enum ErrorEnum {
   // 200 alias
   ALIAS_NOT_EXIST = 200;
   ALIAS_EXIST = 201;
+
+  // document upsert
+  UPSERT_INVALID_PARAMS = 300;
+  // document query
+  QUERY_INVALID_PARAMS_SHOULD_NOT_HAVE_VECTOR_FIELD = 320;
+  QUERY_INVALID_PARAMS_BOTH_DOCUMENT_IDS_AND_FILTER = 321;
+  QUERY_INVALID_PARAMS_LENGTH_OF_DOCUMENT_IDS_BEYOND_500 = 322;
+  QUERY_INVALID_PARAMS_SHOULD_HAVE_ONE_OF_DOCUMENT_IDS_OR_FILTER = 323;
+
+  // document search
+  SEARCH_INVALID_PARAMS_BOTH_DOCUMENT_IDS_AND_VECTOR = 340;
+  SEARCH_INVALID_PARAMS_LENGTH_OF_DOCUMENT_IDS_BEYOND_100 = 341;
+  SEARCH_INVALID_PARAMS_SHOULD_HAVE_ONE_OF_DOCUMENT_IDS_OR_FILTER = 342;
+
+  // document delete
+  DELETE_INVALID_PARAMS_SHOULD_NOT_HAVE_VECTOR_FIELD = 360;
+  DELETE_INVALID_PARAMS_BOTH_DOCUMENT_IDS_AND_VECTOR = 361;
+  DELETE_INVALID_PARAMS_LENGTH_OF_DOCUMENT_IDS_BEYOND_500 = 362;
+  DELETE_INVALID_PARAMS_SHOULD_HAVE_ONE_OF_DOCUMENT_IDS_OR_FILTER = 363;
 }
 
 enum SearchResultCode {

diff --git a/internal/proto/vearchpb/data_model.pb.go b/internal/proto/vearchpb/data_model.pb.go
diff --git a/internal/proto/vearchpb/errors.pb.go b/internal/proto/vearchpb/errors.pb.go
diff --git a/internal/proto/vearchpb/raftcmd.pb.go b/internal/proto/vearchpb/raftcmd.pb.go
diff --git a/internal/proto/vearchpb/router_grpc.pb.go b/internal/proto/vearchpb/router_grpc.pb.go
diff --git a/internal/proto/vearchpb/snapshot.pb.go b/internal/proto/vearchpb/snapshot.pb.go