Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update part.is_title field description #216

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pwoznic
Copy link
Contributor

@pwoznic pwoznic commented Dec 30, 2023

Fixes #212

Updated part.is_title field to include when it's not equal to true (<>). This is useful when documents do not have titles and you want to search for sections without titles. Setting to false will not work because there are cases where this field is unset.

Updated part.is_title field to include when it's not equal to true (<>). This is useful when documents do not have titles and you want to search for sections without titles. Setting to false will not work because there are cases where this field is unset.
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for luxury-shortbread-acee05 ready!

Name Link
🔨 Latest commit 9fa26cd
🔍 Latest deploy log https://app.netlify.com/sites/luxury-shortbread-acee05/deploys/6675ff380174860008518f10
😎 Deploy Preview https://deploy-preview-216--luxury-shortbread-acee05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pwoznic pwoznic marked this pull request as ready for review December 30, 2023 00:04

* To filter for title fields only, use `part.is_title = true`
* To return only non-title sections, use `part.is_title = false`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how part.is_title = false works.
Perhaps it'd be useful to clarify with an example document that is indexed to show what is included or not included with each case?

Going through issues and updated part.is_title to be more clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The explanation of how is_title works is confusing
2 participants